Repository navigation
fix(deps): update starknet-p2p-specs require to valid commit hash - #4196
Open
barsanmaity wants to merge 2 commits into
Open
barsanmaity wants to merge 2 commits into
barsanmaity wants to merge 2 commits into
Conversation
Signed-off-by: Barsan <barsanmaity7@gmail.com>
brbrr
requested changes
Oct 23, 2026
brbrr
left a comment
brbrr
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR, but it needs tweaking. Please check the inline comment
Signed-off-by: Barsan <barsanmaity7@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4196 +/- ##
==========================================
- Coverage 80.85% 80.82% -0.04%
==========================================
Files 512 512
Lines 39084 39124 +40
==========================================
+ Hits 31601 31621 +20
- Misses 7474 7494 +20
Partials 9 9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4136
Updated the
requiredirective forstarknet-p2p-specsto a valid upstream commit hash.This resolves the module graph failure for downstream projects (like
cre-cli) caused by the placeholder pseudo-version. I left the localreplacedirective intact at the bottom so that Juno's local builds using generated protobufs continue working without any issues.